Update Statistics To Realtime w/ Caching #194

ASankaran · 2018-01-29T04:28:11Z

Write registration, rsvp, and live stats to database and cache in realtime
Read stats back from cache when possible
Read stats from db and write to cache when needed
Remove outdated stats (ie. tracks)
Update docs

…eeded

ASankaran · 2018-01-29T04:29:09Z

Slightly updated response format:

{
    "meta": null,
    "data": {
        "registration": {
            "school": {
                "University of Illinois at Urbana-Champaign": 4
            },
            "transportation": {
                "BUS_REQUESTED": 0,
                "INTERNATIONAL": 0,
                "IN_STATE": 0,
                "NOT_NEEDED": 9,
                "OUT_OF_STATE": 0
            },
            "diet": {
                "GLUTEN_FREE": 0,
                "NONE": 9,
                "VEGAN": 0,
                "VEGETARIAN": 0
            },
            "shirtSize": {
                "L": 0,
                "M": 8,
                "S": 0,
                "XL": 0
            },
            "gender": {
                "FEMALE": 0,
                "MALE": 9,
                "NON_BINARY": 0,
                "OTHER": 0
            },
            "graduationYear": {
                "2019": 3
            },
            "isNovice": {
                "0": 0,
                "1": 9
            },
            "status": {
                "ACCEPTED": 0,
                "PENDING": 0,
                "REJECTED": 0,
                "WAITLISTED": 0
            },
            "major": {
                "Computer Science": 4
            },
            "attendees": {
                "count": 9
            }
        },
        "rsvp": {
            "school": {
                "University of Illinois at Urbana-Champaign": 1
            },
            "transportation": {
                "BUS_REQUESTED": 0,
                "INTERNATIONAL": 0,
                "IN_STATE": 0,
                "NOT_NEEDED": 1,
                "OUT_OF_STATE": 0
            },
            "diet": {
                "GLUTEN_FREE": 0,
                "NONE": 1,
                "VEGAN": 0,
                "VEGETARIAN": 0
            },
            "shirtSize": {
                "L": 0,
                "M": 1,
                "S": 0,
                "XL": 0
            },
            "gender": {
                "FEMALE": 0,
                "MALE": 1,
                "NON_BINARY": 0,
                "OTHER": 0
            },
            "graduationYear": {
                "2019": 1
            },
            "isNovice": {
                "0": 0,
                "1": 1
            },
            "major": {
                "Computer Science": 1
            },
            "attendees": {
                "count": 0
            }
        },
        "liveevent": {
            "attendees": {
                "count": 17
            },
            "events": {
                "Example Event": 1
            }
        }
    }
}

Mail List fix

redsn0w422 · 2018-02-08T16:24:44Z

What's the status on this?

YashoSharma

Also are there no changes to the stats controller/service?

YashoSharma · 2018-02-08T18:02:41Z

api/v1/controllers/RSVPController.js

@@ -4,7 +4,7 @@ const services = require('../services');
 const middleware = require('../middleware');
 const requests = require('../requests');
 const roles = require('../utils/roles');
-const mail = require('../utils/mail');
+const config = require('../../config');


YashoSharma · 2018-02-09T06:03:23Z

api/v1/models/Stat.js

+const Model = require('./Model');
+const validators = require('../utils/validators');
+
+const CATEGORIES = ['registration', 'rsvp', 'liveevent'];


YashoSharma · 2018-02-09T06:08:59Z

api/v1/models/Stat.js

+    category: category,
+    stat: stat,
+    field: field
+  }).query().count().then((count) => _Promise.resolve(count[0]['count(*)'] > 0));


Can you do .where().count()

YashoSharma · 2018-02-09T06:15:35Z

api/v1/models/Stat.js

+    amount = 1;
+  }
+
+  const s = Stat.query((qb) => {


return Stat.where().fetch().increment()

YashoSharma · 2018-02-09T06:16:01Z

api/v1/models/TrackingEvent.js

@@ -17,4 +17,10 @@ TrackingEvent.findByName = function(searchName) {
    .fetch();
 };

+TrackingEvent.findAll = function() {


I don't believe this is necessary

Stats Service needs it to query all the tracked events and report the number of people who checked in.

YashoSharma · 2018-02-09T06:16:11Z

api/v1/services/CheckInService.js

@@ -61,6 +62,8 @@ module.exports.createCheckIn = (attributes) => {
  const credentialsRequested = attributes.credentialsRequested;
  delete attributes.credentialsRequested;

+  StatsService.incrementStat('liveevent', 'attendees', 'count');


YashoSharma · 2018-02-09T06:17:10Z

api/v1/services/RSVPService.js

@@ -22,6 +25,18 @@ module.exports.getRSVPById = (id) => RSVP.findById(id);
 * @throws {InvalidParameterError} thrown when an attendee already has an rsvp
 */
 module.exports.createRSVP = (attendee, user, attributes) => {
+
+  StatsService.incrementStat('rsvp', 'school', attendee.get('school'));


preferably the controller has a const array which designates which fields to increment and then you can call the stat update function for-each element of the array

YashoSharma · 2018-02-09T06:18:43Z

api/v1/services/TrackingService.js

@@ -66,6 +69,8 @@ module.exports.addEventParticipant = (participantId) => {

      currentEvent = result;

+      StatsService.incrementStat('liveevent', 'events', currentEvent);


live_event

YashoSharma · 2018-02-09T06:19:43Z

database/migration/V20171011_2012__addStats.sql

+
+INSERT INTO `stats` (`category`, `stat`, `field`) VALUES ('liveevent', 'attendees', 'count');
+
+#INSERT INTO `stats` (`category`, `stat`, `field`) VALUES ('liveevent', `status`, `ACCEPTED`);


Cleaning up this sql table would be nice

vsui and others added 16 commits November 8, 2017 20:31

add stats

f58d8ec

Merge branch 'master' into add-stats

68891bc

Fixed broken rsvp test

c3cc662

Add method to check if stat exists in database

90725d6

Fixed stat increment and update stats on attendee registration

16489ae

Add missing catch when querying stat

c8eaa9d

Write all registration stats to db on signup

37cd7cf

Fixed mail list bug in RSVPController

ad7f1aa

Update stats on attendee rsvp

326b893

Update liveevent attendee count on checkin

2ed2ce5

Write stats into cache on increment

c989637

Added function to stats back from database if needed

58134fa

Fetch stats from cache when possible, falling back to database when n…

614c8bd

…eeded

Ran linter and removed old stats code

66a5a1d

Added stats for tracked live events

29e1fcb

Ran linter

c37fa6e

ASankaran changed the base branch from master to staging January 29, 2018 04:28

YashoSharma requested review from nmagerko and shreychowdhary January 29, 2018 06:37

ASankaran and others added 2 commits January 31, 2018 20:28

Updated Docs

0c2b679

Merge pull request #214 from HackIllinois/staging

320f523

Mail List fix

YashoSharma suggested changes Feb 9, 2018

View reviewed changes

ASankaran added 2 commits February 11, 2018 23:44

Merged master

212c4cc

Rename liveevent to live_event

8560392

ASankaran changed the title ~~Update Statistics To Realtime w/ Caching~~ WIP: Update Statistics To Realtime w/ Caching Feb 19, 2018

ASankaran added 3 commits February 21, 2018 21:12

Write stats to cache in series

eee93e3

Decrement RSVP stats on changing accept to decline

2c7d064

Removed stats test

6b4b68c

ASankaran added 4 commits February 21, 2018 22:07

Reverted rsvp tests

d54acb4

Removed unused stat function

7144f39

Refactored stats increment calls

14ed003

Removed promise nesting

9ca2538

ASankaran changed the title ~~WIP: Update Statistics To Realtime w/ Caching~~ Update Statistics To Realtime w/ Caching Feb 23, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Statistics To Realtime w/ Caching #194

Update Statistics To Realtime w/ Caching #194

ASankaran commented Jan 29, 2018 •

edited

Loading

ASankaran commented Jan 29, 2018

redsn0w422 commented Feb 8, 2018

YashoSharma left a comment

YashoSharma Feb 8, 2018

YashoSharma Feb 9, 2018

YashoSharma Feb 9, 2018

YashoSharma Feb 9, 2018

YashoSharma Feb 9, 2018

ASankaran Feb 22, 2018

YashoSharma Feb 9, 2018

YashoSharma Feb 9, 2018

YashoSharma Feb 9, 2018

YashoSharma Feb 9, 2018

		@@ -66,6 +69,8 @@ module.exports.addEventParticipant = (participantId) => {

		currentEvent = result;

		StatsService.incrementStat('liveevent', 'events', currentEvent);


		INSERT INTO `stats` (`category`, `stat`, `field`) VALUES ('liveevent', 'attendees', 'count');

		#INSERT INTO `stats` (`category`, `stat`, `field`) VALUES ('liveevent', `status`, `ACCEPTED`);

Update Statistics To Realtime w/ Caching #194

Are you sure you want to change the base?

Update Statistics To Realtime w/ Caching #194

Conversation

ASankaran commented Jan 29, 2018 • edited Loading

ASankaran commented Jan 29, 2018

redsn0w422 commented Feb 8, 2018

YashoSharma left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ASankaran commented Jan 29, 2018 •

edited

Loading