Quick UI Fixes #580
Merged
Quick UI Fixes #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… schedule seg control
lasyaneti
reviewed
Feb 21, 2024
HIAPI/Models/Attendee.swift
Outdated
| @@ -21,7 +21,7 @@ public struct Attendee: Codable, APIReturnable { | |||
| public let id: String | |||
| public let firstName: String? | |||
| public let lastName: String? | |||
| public let email: String | |||
| public let email: String? // Email should be an optional field because not every GH account has their email set to public | |||
There was a problem hiding this comment.
Technically this email should be required since Attendees provide these at Registration
lasyaneti
reviewed
Feb 21, 2024
| @@ -15,7 +15,7 @@ import Foundation | |||
|
|
|||
| public struct User: Codable, APIReturnable { | |||
| public let userId: String | |||
| public let email: String | |||
| public let email: String? // Email should be an optional field because not every GH account has their email set to public | |||
There was a problem hiding this comment.
This is the one that should be optional, yes!
Make email required
lasyaneti
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description