Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Staff Attendance Error #600

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Fixed Staff Attendance Error #600

merged 4 commits into from
Dec 11, 2024

Conversation

yashjagtap23
Copy link
Contributor

@yashjagtap23 yashjagtap23 commented Dec 11, 2024 •
edited
Loading

Description

Fixes #598

  • fixed error popup even when QR code was successfully scanned in back end

Todos

  • can still be more specific about error messages
  • Possibly close QR code scanner if QR code / event is expired

Screenshots

giphy

@yashjagtap23
works but without good error descriptions
91e7411 
removed error descriptions for now to simplify. Error seems to be due to missing field in event.swift for boolean success
@yashjagtap23
added back specific errors
c571f09
@yashjagtap23
Removed unneccesary prints
26ebaec
anushkasankaran
anushkasankaran approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@anushkasankaran anushkasankaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@yashjagtap23 yashjagtap23 merged commit 3bfd717 into dev Dec 11, 2024
2 checks passed
@yashjagtap23 yashjagtap23 deleted the Yash/random-branch branch December 11, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anushkasankaran anushkasankaran anushkasankaran approved these changes

@lasyaneti lasyaneti Awaiting requested review from lasyaneti lasyaneti is a code owner

@s0phialiu s0phialiu Awaiting requested review from s0phialiu s0phialiu is a code owner

@AydanPirani AydanPirani Awaiting requested review from AydanPirani AydanPirani is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Staff Attendance QR Scanning
2 participants
@yashjagtap23 @anushkasankaran