Mentor Page #27
Merged
Mentor Page #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, looking great so far!! Yeah don't worry about the NavBar, I'll work on that |
abhinavpappu
added a commit
that referenced
this pull request
Apr 9, 2021
* mentor page initial * finish the mentor page thing * minor edits * Add mentor data + minor style changes * Add mentors to nav bar + style updates * Add fireflies * Remove unnecessary import Co-authored-by: Abhinav Pappu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentor page pull request.
At the time of pull request, the mentor page desktop version is just about done. Some dummy data is in the code so definitely don't merge. Somethings were a little hacky to get in position like the trees and the responsiveness is also finnicky.
What's left to do?
Mobile Version
NavBar -- But the navbar is universal between all the other pages so if one is made you can just plop it in here, or I can tackle that if you want.
I omitted a few stars and don't think I've added in the fireflies yet. I wasn't sure how to handle really tall screens or really wide screens. (I was lazy and copied the entire ground SVG which works well for reasonable screen ratios, but breaks for extreme ones)