Skip to content
This repository has been archived by the owner on Jun 11, 2023. It is now read-only.

Send origin gateway data when joining remote servers #292

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Send origin gateway data when joining remote servers #292

merged 1 commit into from
Oct 18, 2017

Conversation

chrisfls
Copy link
Contributor

@chrisfls chrisfls commented Oct 18, 2017


This change is Reviewable

@PedroHLC
Copy link
Contributor

:lgtm:


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


src/Game/Update.elm, line 224 at r1 (raw file):

                |> List.map (joinRemote playerServer)
    in
        Dispatch.batch (myDispatch :: otherDispatches)

nice approach!


src/Game/Update.elm, line 269 at r1 (raw file):

                    payload =
                        -- TODO: include bounce_id after settling

#291


Comments from Reviewable

@chrisfls chrisfls merged commit fa1ef15 into HackerExperience:master Oct 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants