Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Coding Style Guide Documentation #20

Closed
fujitatomoya opened this issue May 30, 2023 · 2 comments · Fixed by #22
Closed

[FR] Coding Style Guide Documentation #20

fujitatomoya opened this issue May 30, 2023 · 2 comments · Fixed by #22

Comments

@fujitatomoya
Copy link
Collaborator

Feature request

Motivation

Coding Style should be provided to accept the PR as guideline.

Feature description

We can refer to Google C++ Style Guideline, and if necessary we can define our own policy and rules.

Implementation considerations

Provide coding style guideline on top page.
@fujitatomoya fujitatomoya mentioned this issue May 30, 2023
Closed
@Windrow14
Copy link
Collaborator

We may align with Haivision/srt's code style if it has a more clear one someday.

https://github.com/Haivision/srt/blob/master/CONTRIBUTING.md#code-style
https://github.com/Haivision/srt/blob/master/docs/dev/developers-guide.md#coding-rules

@Windrow14 Windrow14 linked a pull request Jun 15, 2023 that will close this issue
Code modification according to cpplint. Add coding style check job in workflow. #22
Merged
@fujitatomoya fujitatomoya mentioned this issue Jun 15, 2023
Merged
@fujitatomoya
Copy link
Collaborator Author

closing in favor of #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fujitatomoya @Windrow14