Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code modification according to cpplint. Add coding style check job in workflow. #22

Merged
merged 16 commits into from
Mar 10, 2024
Merged

Code modification according to cpplint. Add coding style check job in workflow. #22

merged 16 commits into from
Mar 10, 2024

Conversation

Windrow14
Copy link
Collaborator

@Windrow14 Windrow14 commented Jun 14, 2023 •
edited by fujitatomoya
Loading

address #21 and #20

@Windrow14 Windrow14 changed the title Code modification according to cpplint. [WIP] Code modification according to cpplint. Jun 14, 2023
@fujitatomoya
Copy link
Collaborator

@Windrow thanks for opening PR. but #21 was meant to add workflow to integrate cpplint and code checker, not fixing the code itself. we can keep this open for the part of #21, could you add workflow with cpplint?

@Windrow14 Windrow14 self-assigned this Jun 15, 2023
@Windrow14 Windrow14 requested a review from fujitatomoya June 15, 2023 05:32
@Windrow14 Windrow14 changed the title [WIP] Code modification according to cpplint. Code modification according to cpplint. Add coding style check job in workflow. Jun 15, 2023
@Windrow14 Windrow14 added the enhancement New feature or request label Jun 15, 2023
This was linked to issues Jun 15, 2023
[FR] Coding style checker and workflow integration #21
Closed
[FR] Coding Style Guide Documentation #20
Closed
@Windrow14 Windrow14 added the documentation Improvements or additions to documentation label Jun 15, 2023
@fujitatomoya
Copy link
Collaborator

@Windrow14 is this ready to review?

@Windrow14
Copy link
Collaborator Author

@Windrow14 is this ready to review?

Yes! Please take a look.

fujitatomoya
fujitatomoya requested changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, could you take a look at them?

include/srtexp_config.hpp Show resolved Hide resolved
include/srtexp_config.hpp Show resolved Hide resolved
scripts/check-coding-style.sh Show resolved Hide resolved
scripts/check-coding-style.sh Show resolved Hide resolved
@fujitatomoya
Copy link
Collaborator

@Windrow14 i think this needs to be rebased.

@Windrow14
Copy link
Collaborator Author

Windrow14 commented Jan 29, 2024 •
edited
Loading

@Windrow14 i think this needs to be rebased.

Rebased.

What's your opinion on the replies to your early comments? Seems lint does not work in the way we want...

fujitatomoya
fujitatomoya approved these changes Mar 10, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would do some more cosmetic changes for cpplint and script, but thanks this is good to merge.

@fujitatomoya fujitatomoya merged commit 4df87f0 into Haivision:master Mar 10, 2024
3 checks passed
This was referenced Mar 10, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@Windrow14 Windrow14

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Coding style checker and workflow integration [FR] Coding Style Guide Documentation
2 participants
@Windrow14 @fujitatomoya