-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc update: installation on Ubuntu 22 Jammy Jellyfish. #27
doc update: installation on Ubuntu 22 Jammy Jellyfish. #27
Conversation
Signed-off-by: Tomoya.Fujita <[email protected]>
this is still W.I.P since we have been having the following build issue with https://github.com/jupp0r/prometheus-cpp [ 90%] Linking CXX executable ../../../bin/prometheus_push_internal_test
/usr/bin/ld: CMakeFiles/prometheus_push_internal_test.dir/label_encoder_test.cc.o: in function `prometheus::(anonymous namespace)::LabelEncoderTest::Encode(std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > const&)':
label_encoder_test.cc:(.text+0x58): undefined reference to `prometheus::detail::encodeLabel(std::ostream&, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > const&)'
collect2: error: ld returned 1 exit status
make[2]: *** [push/tests/internal/CMakeFiles/prometheus_push_internal_test.dir/build.make:87: bin/prometheus_push_internal_test] Error 1
make[1]: *** [CMakeFiles/Makefile2:703: push/tests/internal/CMakeFiles/prometheus_push_internal_test.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs.... that happens on ubuntu 20 and 22. |
workflow is broken with this issue too, see https://github.com/Haivision/srt-prometheus-exporter/actions/runs/7534771679/job/20509698525?pr=27 |
we need to solve this build error, see more details for jupp0r/prometheus-cpp#687 |
Signed-off-by: Tomoya Fujita <[email protected]>
Signed-off-by: Tomoya Fujita <[email protected]>
jupp0r/prometheus-cpp#687 has been addressed by jupp0r/prometheus-cpp@2f528e2 |
``` | ||
|
||
### Dependent Packages | ||
|
||
- [prometheus-cpp](https://github.com/jupp0r/prometheus-cpp) library | ||
|
||
> [!NOTE] | ||
> `prometheus-cpp` debian package is supported on ubuntu 23 or later. see more details for https://github.com/Haivision/srt-prometheus-exporter/issues/11. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately we still need to build the prometheus-cpp
client library with ubuntu 22.04.
The stable version can be installed with `apt install libsrt-dev` on `Ubuntu 20.04` version is `v1.4.0`. | ||
**If SRT library is compiled from code, be sure that the code is reset to tag `v1.4.0`. Otherwise, srt_exporter library compiled would not work with installed SRT library on other devices. Make sure that SRT Exporter library is built and running based on the same version of SRT library.** | ||
> [!NOTE] | ||
> **If SRT library is compiled from code, be sure that the code is aligned with tag `v1.4.X`. Otherwise, srt_exporter library would not get successfully compiled with installed SRT library.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having the semantic version control should be able to be compatible with any patch releases. that means, as long as that SRT version is v1.4.X
, that should be compatible with other libraries.
@Windrow14 i know you are on vacation, so i will go ahead to merge this with green CI. |
part of #25