Fix warnings #30
Open
Fix warnings #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a ModelForm without either the 'fields' attribute or the 'exclude' attribute is deprecated. Added 'exclude'.
bkus
reviewed
Mar 1, 2023
| @@ -58,3 +58,4 @@ def _rev_to_ip(self, name): | |||
|
|
|||
| class Meta: | |||
| model = Record | |||
| exclude = [] | |||
There was a problem hiding this comment.
There seems to be a security warning against this approach:
https://docs.djangoproject.com/en/1.8/topics/forms/modelforms/#selecting-the-fields-to-use
bkus
reviewed
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now run
make testto run the tests in a container. They were reporting a bunch of deprecation warnings, so I resolved them one by one (see commit messages).