Skip to content

Commit

Permalink
style: use idiomatic single letter reciever
Browse files Browse the repository at this point in the history
  • Loading branch information
HandOfGod94 committed Sep 9, 2023
1 parent 6a48c41 commit 86636ee
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions pkg/jira_changelog/generator.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,15 @@ const (

func NewGenerator(jiraConfig jira.Config, fromRef, toRef, repoURL string) *Generator {
client := jira.NewClient(jiraConfig)
generator := &Generator{
g := &Generator{
JiraConfig: jiraConfig,
fromRef: fromRef,
toRef: toRef,
repoURL: repoURL,
client: client,
}

generator.FSM = fsm.NewFSM(
g.FSM = fsm.NewFSM(
Initial,
fsm.Events{
{Name: FetchCommits, Src: []string{Initial}, Dst: CommitsFetched},
Expand All @@ -64,27 +64,27 @@ func NewGenerator(jiraConfig jira.Config, fromRef, toRef, repoURL string) *Gener
e.Cancel(err)
return
}
generator.commits = commits
g.commits = commits
},
Before(FetchJiraIssues): func(ctx context.Context, e *fsm.Event) {
issues, err := generator.fetchJiraIssues(generator.commits)
issues, err := g.fetchJiraIssues(g.commits)
if err != nil {
e.Cancel(err)
return
}
generator.jiraIssues = issues
g.jiraIssues = issues
},
Before(GroupJiraIssues): func(ctx context.Context, e *fsm.Event) {
jiraIssues := lo.Uniq(generator.jiraIssues)
jiraIssues := lo.Uniq(g.jiraIssues)
slog.Debug("Total jira issues ids", "count", len(jiraIssues))

issuesByEpic := lo.GroupBy(jiraIssues, func(issue jira.Issue) string { return issue.Epic() })
generator.changes = issuesByEpic
g.changes = issuesByEpic
},
},
)

return generator
return g
}

func panicIfErr(err error) {
Expand Down

0 comments on commit 86636ee

Please sign in to comment.