Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatpak #7

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Flatpak #7

merged 5 commits into from
Dec 4, 2024

Conversation

cassidyjames
Copy link
Contributor

Adds a Flatpak manifest, launcher.desktop, and metainfo.xml as required for Flathub. Depends on #5; would need updating to point to upstream releases if that's merged.

Point people upstream
This adds CI to publish Linux builds. How it works:

- Export ROTA from source using Godot Engine
- Upload that export as a build artifact
- On GitHub releases, attach that build artifact to the release

Eventually this could be expanded to build a Flatpak, a prerequisite to
getting it onto Flathub.

I intended to use the [godot-ci GitHub
Action](https://github.com/marketplace/actions/godot-ci) for CI, but it
doesn't currently support Godot 3.6 (see: abarichello/godot-ci#155). So
for now, I'm using
[docker.io/smks/godot-ci](https://hub.docker.com/r/smks/godot-ci) which
is a container image forked from the former and just updated for 3.6.
Borderless is unexpected on Linux, and explicitly discouraged by the
[Flathub Quality Guidelines][1]. This can still be toggled off from the
in-game options if players prefer.

[1]:
https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/quality-guidelines/#include-window-shadow-and-rounded-corners
@HarmonyHoney HarmonyHoney marked this pull request as ready for review December 4, 2024 19:09
@HarmonyHoney HarmonyHoney marked this pull request as draft December 4, 2024 19:11
@HarmonyHoney HarmonyHoney marked this pull request as ready for review December 4, 2024 19:19
@HarmonyHoney HarmonyHoney merged commit 143c2ef into HarmonyHoney:master4 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants