Merge pull request #442 from HausDAO/fix/decoded-actions-array

Fix decoding actions with array params
HausDAO · Nov 9, 2023 · 4d83cce · 4d83cce
2 parents 63368ff + 0ce1e5d
commit 4d83cce
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/libs/moloch-v3-macro-ui/src/utils/proposalDetailsHelpers.ts b/libs/moloch-v3-macro-ui/src/utils/proposalDetailsHelpers.ts
@@ -48,12 +48,20 @@ const getValueFromMintOrTransferAction = (
     return 'decoding error';
   }
 
-  const value = Array.isArray(actionData.params[1].value)
-    ? (actionData.params[1].value[0] as bigint)
-    : (actionData.params[1].value as bigint);
+  const value = actionData.params[1].type.endsWith('[]')
+    ? actionData.params[1].value
+        .toString()
+        .split(',')
+        .map((v) => BigInt(v))
+    : [BigInt(actionData.params[1].value.toString())];
 
   return formatValueTo({
-    value: toWholeUnits(value.toString(), decimals),
+    value: toWholeUnits(
+      value
+        .reduce((val: bigint, accValue: bigint) => accValue + val, BigInt(0))
+        .toString(),
+      decimals
+    ),
     decimals: 2,
     format: 'numberShort',
   });

diff --git a/libs/tx-builder/src/utils/deepDecoding.ts b/libs/tx-builder/src/utils/deepDecoding.ts
@@ -157,7 +157,11 @@ const decodeMethod = (options: {
   const inputsWithValues = (inputs as any[]).map((input, index) => ({
     name: input.name,
     type: input.type,
-    value: result.args?.[index]?.toString() || '0x',
+    value: Array.isArray(result.args?.[index])
+      ? (result.args?.[index] as Array<any>).length
+        ? (result.args?.[index] as Array<any>).toString()
+        : '[]'
+      : result.args?.[index]?.toString() || '0x',
   }));
 
   return {