Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/offering enforcement #418

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Fix/offering enforcement #418

merged 3 commits into from
Sep 14, 2023

Conversation

dekanbro
Copy link
Contributor

GitHub Issue

fixes #356

Changes

changes checks on proposal offering and sponsor to delegatedShares instead of shares.

Packages Added

NA

Checks

Before making your PR, please check the following:

  • [ X] Critical lint errors are resolved
  • [ X] App runs locally
  • [ X] App builds locally (run the build command for any impacted package and check for any errors before the PR)

@skuhlmann skuhlmann merged commit 5868d44 into develop Sep 14, 2023
1 check passed
@skuhlmann skuhlmann deleted the fix/offering-enforcement branch September 14, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skuhlmann skuhlmann skuhlmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal Offering is enforced by UI when not needed
2 participants
@dekanbro @skuhlmann