Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better gas estimation by incorporating estimated overhead for action #448

Merged
merged 3 commits into from
Nov 9, 2023
Merged

better gas estimation by incorporating estimated overhead for action #448

merged 3 commits into from
Nov 9, 2023

Conversation

dekanbro
Copy link
Contributor

@dekanbro dekanbro commented Nov 7, 2023

GitHub Issue

Bad gas estimates on multicall
more on #422

Changes

adding a gas buffer on every multicall action to account for extra overhead

Packages Added

Brief list of any packages added, and if folks need to rerun yarn install to run locally

Checks

Before making your PR, please check the following:

  • [ X] Critical lint errors are resolved
  • [ X] App runs locally
  • [ X] App builds locally (run the build command for any impacted package and check for any errors before the PR)

@dekanbro dekanbro marked this pull request as ready for review November 7, 2023 23:01
@dekanbro dekanbro requested a review from santteegt November 8, 2023 16:26
@dekanbro
Copy link
Contributor Author

dekanbro commented Nov 8, 2023 •
edited
Loading

another example of a failed proposal because of bad baalgas https://admin.daohaus.fun/#/molochV3/0x64/0x7ca3494cc9b31afa05c2f51ba5a2aa5affb3b659/proposal/26

re simulated with more gas
https://dashboard.tenderly.co/dekan/project/simulator/2fe52a7d-09a0-45c3-bff6-7fc63b9bb0cd

santteegt
santteegt reviewed Nov 8, 2023
View reviewed changes
libs/utils/src/utils/gas.ts Outdated Show resolved Hide resolved
libs/tx-builder/src/utils/multicall.ts Show resolved Hide resolved
@santteegt santteegt merged commit e4ae1c7 into develop Nov 9, 2023
1 check passed
@santteegt santteegt deleted the feat/betterGasEstimation branch November 9, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santteegt santteegt santteegt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dekanbro @santteegt