Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Deterministic SNR #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ark0015
Copy link
Contributor

@ark0015 ark0015 commented Oct 18, 2019

Here are some test plots to show it works. The figures are an addition to the GWBSensitivity tutorial plots.

deter_sens_SNR_curves
deter_SNR_curves

@Hazboun6
Copy link
Owner

Hazboun6 commented Oct 22, 2019

@ark0015 This is looking pretty good! Really good start. I think it just needs a few tweaks. First let's refer to Issue #1 which is what this pull request is concerning.

Since the DeterSensitivityCurve works for all deterministic curves, I think I'd rather not assume that it calculates the SNR for a circular binary. Take a look at the SNR for the GWBSensitivityCurve it doesn't actually assume the form of the background.

One other thing is that the proper use of the astropy.units would be to call return snr.to('').value, so that it converts to the correct units for you .

@ark0015
Copy link
Contributor Author

ark0015 commented Nov 8, 2019

So I tried a few different things, but I think just generalizing the naming to just h_0 is what I settled on. It produces identical results to those in my first commits.

Originally, I thought it would be a good idea to just move the SNR calculation in GWBSensitivityCurve out of the class to use as a general function that takes in S_eff, Sh, freqs, Tspan for any sensitivity curve and source Sh. Then the Sh for a monochromatic source would be eqn. 50 from the paper. It definitely is the most general case, and would work for any strain PSD.
The issue was that this method returned a much higher SNR estimation than the one given in my examples above for eqn. 76 for the monochromatic case using eqn. 50. I suspect because the delta approximations spread the power over so many frequencies that it really is not a good approximation of the delta function over the observation time at such low frequencies. I can provide plots that show this if you would like to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants