re-match #214
Merged
re-match #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for dapper-gnome-2a669c failed.
|
pichot
reviewed
Sep 12, 2024
app/server/api/dtpr/v0/[locale].ts
Outdated
| @@ -6,7 +6,7 @@ export default defineEventHandler(async event => { | |||
| const { siteUrl } = useRuntimeConfig(); | |||
| const locale = event.context.params?.locale || 'en'; | |||
|
|
|||
| const iconUrl = (icon: string) => { | |||
| const iconUrl = (icon: /dtpr-icons/string) => { | |||
There was a problem hiding this comment.
This shouldn't change. I think a search and replace got here by accident.
There was a problem hiding this comment.
Oh, thanks for catching this you're completely right
pichot
reviewed
Sep 12, 2024
prototypes/vision/src/template.ejs
Outdated
There was a problem hiding this comment.
Same for this file. Search and replace was too aggressive
reverses overly ambitious find and replace
helpful-places-it
temporarily deployed
to
fix-icon-bug - dtpr-io-static PR #214
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matches markdown files with correct icons