Support for extending native elements via polyfill #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as Safari refuses to extend native elements like
HTMLButtonElement
a polyfill is needed for that. I've tested @ungap/custom-elements-builtin recently with Safari 13.1 and Safari TP 109.This PR
test/define.test.js
)define()
tests to Karma for testing on real browsers without mocking the CustomElements APIConcerning the tests:
If that is the case, such a CI looks pretty useless to me...
There are a lot of changes in this PR and I did not bother to match the projects code style. Right now that would have been too much of a burden to me and my time is scarce.
I like to present my work here anyway because I think the added functionality is useful and this project has been silence for a while now.