Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18next installation (hungarian translations), simplification of repetitive parts #7

Open
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

BiRo96
Copy link

@BiRo96 BiRo96 commented Oct 22, 2022

I translated the whole website to hungarian, and wrote a documentation for future translations.
On the other hand I simplified repetitive parts of the website by tearing them down into components.
(I left downloads page as it is, because the variables are not used equally everywhere, card structures differ too much and other parts were a bit hard to simplify)

@BiRo96
Copy link
Author

BiRo96 commented Oct 22, 2022

I just have to figure out, how to redirect the index page to the english index page, if no regional code is given in the URL

@BiRo96
Copy link
Author

BiRo96 commented Oct 22, 2022

image

@BiRo96
Copy link
Author

BiRo96 commented Oct 22, 2022

There is a little problem with the frontend on the Support Us page, but I have never used pico, so I don't know how to fix this
image
It does not appear in Download page, which is weird...
image

@BiRo96
Copy link
Author

BiRo96 commented Oct 22, 2022

There are minor thing that should be fixed in Typescript assignability to build the website.
I'm on it.

@BiRo96
Copy link
Author

BiRo96 commented Oct 22, 2022

I just have to figure out, how to redirect the index page to the english index page, if no regional code is given in the URL

done 😄

@BiRo96
Copy link
Author

BiRo96 commented Oct 22, 2022

If you, guys, could help me with this pico css frontend article problem, then I guess it's ready...

Maybe we should do something with this select tag in mobile size, but it's not big problem, I guess
image

image

@BiRo96
Copy link
Author

BiRo96 commented Oct 24, 2022

I simplified the Downloads page's articles' repetitive code too

@flavioislima
Copy link
Member

I think might be too much stuff to put on navbar, maybe move it to the footer.

@BiRo96
Copy link
Author

BiRo96 commented Jan 19, 2023

I'm trying to catch up with the development process. 😄

@BiRo96
Copy link
Author

BiRo96 commented Jan 19, 2023

And now the language selector is on the Footer, which actually looks much better on each size of the screen!
Image
Image

@BiRo96
Copy link
Author

BiRo96 commented Jan 19, 2023

I'm done 😄 👍🏻 @flavioislima

@BiRo96
Copy link
Author

BiRo96 commented Jan 19, 2023

There is a little problem with the frontend on the Support Us page, but I have never used pico, so I don't know how to fix this image It does not appear in Download page, which is weird... image

fixed this too :)
It was a missing class that makes the download cards flexible, but not in the donate section, it is still an issue in the current page online.
Now It is fixed in this transformation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants