US69000: Adding support for new volume attributes in schema #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achu-1612
commented
Aug 28, 2024
achu-1612
added
enhancement
mchuang3
reviewed
Aug 28, 2024
|
Please update your PR description about the non-released client version. |
achu-1612
removed
the
DO NOT MERGE
mchuang3
approved these changes
Aug 29, 2024
ron-saito
reviewed
Aug 29, 2024
| @@ -326,6 +371,26 @@ func resourceMetalVolumeRead(d *schema.ResourceData, meta interface{}) (err erro | |||
| return fmt.Errorf("set Size: %v", err) | |||
| } | |||
|
|
|||
| if err = d.Set(vSizeInUse, math.Round(float64(volume.CapacityUsed)/KiBToGBConversion)); err != nil { | |||
| return fmt.Errorf("resourceMetalVolumeRead: set %s : %v", vSizeInUse, err) | |||
There was a problem hiding this comment.
I'd remove "resourceMetalVolumeRead" from the error messages to be more secure.
There was a problem hiding this comment.
As this is a public repo, I decided to put more context to the error on where it is coming from.
Anyway, I have removed the method names to align with other implementations.
Thanks.
ron-saito
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added new volume attributes from the client to the schema.
Client release - https://github.com/HewlettPackard/hpegl-metal-client/releases/tag/v1.5.21
Note: As fields are populated by the backend, they are marked as computed which will make sure the resources are not affected when a re-apply is issued.
Test:
State after creating the volume
tf.state.before.json
Start after refresh the volume post manually data population
tf.state.after.json
Diff of states post manual updates to db record
Re-apply of the resource
