Skip to content

Commit

Permalink
Lint fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
manjunath-batakurki committed Jul 21, 2022
1 parent 7f1efdd commit 8aac952
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -111,5 +111,5 @@ all: lint test
tools:
go env -w GO111MODULE=on
go env -w GOPRIVATE="github.com/hpe-hcss/*"
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.31.0
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.43.0
.PHONY: tools
1 change: 0 additions & 1 deletion golangci-lint-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ linters:
- exhaustivestruct
- cyclop
- varnamelen
- maintidx
- ireturn
#Temporarily disabling wrapcheck
# - wrapcheck
Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance_test/helper.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func getAPIClient() (*api_client.APIClient, api_client.Configuration) {
}

cfg := api_client.Configuration{
Host: os.Getenv("HPEGL_VMAAS_API_URL"),
Host: os.Getenv("HPEGL_VMAAS_API_URL"),
DefaultHeader: headers,
DefaultQueryParams: map[string]string{
constants.LocationKey: os.Getenv("HPEGL_VMAAS_LOCATION"),
Expand Down
1 change: 1 addition & 0 deletions internal/cmp/transport_zone.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,6 @@ func (r *transportZone) Read(ctx context.Context, d *utils.Data, meta interface{
if err != nil {
return err
}

return tftags.Set(d, resp)
}
2 changes: 0 additions & 2 deletions pkg/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ import (
// This must be unique, hpegl will error-out if it isn't
const keyForGLClientMap = "vmaasClient"

var serviceURL string

// Assert that InitialiseClient satisfies the client.Initialisation interface
var _ client.Initialisation = (*InitialiseClient)(nil)

Expand Down

0 comments on commit 8aac952

Please sign in to comment.