[Breaking] Synchronize Job Template with name instead of ID in AWX(RHAAP) #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliasBoulharts
force-pushed
the
job_template_name
branch
from
692eac4
to
b281e3a
Compare
Sispheor
reviewed
Nov 22, 2024
| @@ -1,6 +1,6 @@ | |||
| from unittest.mock import patch, MagicMock | |||
|
|
|||
| from service_catalog.models import JobTemplate, Operation | |||
| from service_catalog.models import JobTemplate, Operation, FakeInstance | |||
Sispheor
reviewed
Nov 22, 2024
|
|
||
| @patch('towerlib.towerlib.Tower.get_job_template_by_name') | ||
| @patch('service_catalog.models.tower_server.TowerServer.get_tower_instance') | ||
| def test_update_non_existing_job_template_from_tower(self, mock_tower_instance, mock_get_job_template_by_name): |
EliasBoulharts
force-pushed
the
job_template_name
branch
from
b281e3a
to
7c75087
Compare
|
Maybe not really the way to go finally. We'll discuss about this next week. |
|
We abord this approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.