Users/swatantra/update packages #49
Open
+35
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idanlevin
reviewed
Mar 16, 2022
| @@ -1,15 +1,34 @@ | |||
| FROM python:3.9-slim | |||
| FROM ubuntu:18.04 as build-env | |||
There was a problem hiding this comment.
hi, there is no need to change the whole Dockerfile, if you had an issue with the not running as root, you can just make it optional in the existing Dockerfile this is a one line change
| msrestazure==0.6.4 | ||
| adal==1.2.7 | ||
| pyopenssl==22.0.0 | ||
| kubernetes==23.3.0 |
There was a problem hiding this comment.
since you're updating some major versions after a long time this project wasn't updated, what kind of tests have you done to make sure nothing is broken?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the packages to latest one.
Docker file updated to use Python 3