Add nickname character limit. #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shall I resolve #294 together? |
NamiUni
commented
Sep 15, 2023
| private int nicknameMinLimit = 3; | ||
|
|
||
| @Comment("Maximum number of characters in nickname.") | ||
| private int nicknameMaxLimit = 16; |
There was a problem hiding this comment.
The reason for the default setting of 16 characters is that MinecraftID can be set to a maximum of 16 characters.
jpenilla
reviewed
Sep 15, 2023
common/src/main/java/net/draycia/carbon/common/command/commands/NicknameCommand.java
Show resolved
Hide resolved
jpenilla
reviewed
Sep 15, 2023
common/src/main/java/net/draycia/carbon/common/config/PrimaryConfig.java
Outdated
Show resolved
Hide resolved
jpenilla
reviewed
Sep 15, 2023
common/src/main/java/net/draycia/carbon/common/messages/CarbonMessages.java
Outdated
Show resolved
Hide resolved
|
Thanks for the review 😘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a character limit on nicknames.
Currently no limit is imposed, so you can set incredibly long names. Fix this.
This pull request serves to indirectly fix this issue #292 , but it is not an essential fix.
Please check the following items.