Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content update #128

Closed
wants to merge 8 commits into from
Closed

Conversation

devamitranjan
Copy link
Contributor

@devamitranjan devamitranjan commented Oct 2, 2024

Motivation

Fixed the failing of the status in the content in the cms.
Fixes #127

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (Storybook)
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@devamitranjan
Copy link
Contributor Author

@marrouchi Please review this and add hacktoberfest label in it. Thanks in advance.

Copy link
Contributor

@marrouchi marrouchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @devamitranjan

Thank you, I think we need to fix this differently.

Currently the controller path operation is using the ContentCreateDto

@CsrfCheck(true)
  @Patch('/:id')
  async updateOne(
    @Body() contentDto: **ContentCreateDto**,
    @Param('id') id: string,
  ): Promise<Content> {

We need to add another Dto for updates when we have two use cases :

  • Either it's to update everyting : title, status, fields
  • Just update the status attribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Update of the content in the cms is getting failed
2 participants