Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add plugins settings i18n + typing #249

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

marrouchi
Copy link
Contributor

@marrouchi marrouchi commented Oct 19, 2024

Motivation

In this PR :

  • We introduce i18n for plugins
  • Enforce typing for plugin settings (arguments)
  • Remove dummy plugin (keep it only for unit tests)

Related PRs:

How to test:

  • Install chatgpt plugin as an example
  • Add a block, check the block message form : inputs should be translated (including helper text)
  • Test the block

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@yassinedorbozgithub yassinedorbozgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marrouchi, i have faced those typescript errors
image

@marrouchi marrouchi changed the base branch from feat/api-i18n to main October 21, 2024 07:47
Copy link
Collaborator

@IkbelTalebHssan IkbelTalebHssan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Hi,
I had this error when starting the project.

Copy link
Collaborator

@yassinedorbozgithub yassinedorbozgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully with Gemini plugin including the updates of this PR : Hexastack/hexabot-plugin-gemini#1
EN:
image
FR:
image

LGTM 🚀

@marrouchi marrouchi merged commit af22a6b into main Oct 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants