Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update translation.json -- [ISSUE] - Uppercase the 1st letter in the NLP Value dialog form fields #31 #34

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Update translation.json -- [ISSUE] - Uppercase the 1st letter in the NLP Value dialog form fields #31 #34

merged 1 commit into from
Sep 22, 2024

Conversation

adititripathi
Copy link
Contributor

@adititripathi adititripathi commented Sep 17, 2024 •
edited
Loading

fix: Uppercase the first letter in NLP Value dialog form fields (#31)

Fixes #31

Type of change

  • Bug fix (non-breaking change which fixes an issue)
Screenshot 2024-09-18 at 12 04 55 AM Screenshot 2024-09-18 at 12 05 01 AM

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (Storybook)
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@adititripathi
Update translation.json
a991559 
fix: Uppercase the first letter in NLP Value dialog form fields (Hexastack#31)
marrouchi
marrouchi requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@marrouchi marrouchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adititripathi for your contribution.

Let's ensure that the same is applied to the french translation fr/translation.json

Also, we need to do the same for "synonyms"

@marrouchi marrouchi merged commit f392ead into Hexastack:main Sep 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marrouchi marrouchi marrouchi requested changes

@yassinedorbozgithub yassinedorbozgithub yassinedorbozgithub approved these changes

@medtaher123 medtaher123 medtaher123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🤔 [ISSUE] - Uppercase the 1st letter in the NLP Value dialog form fields
4 participants
@adititripathi @marrouchi @medtaher123 @yassinedorbozgithub