-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add merge workflow #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general remark, I think we can may do the setup of docker and login once to build all the images.
In the updated workflow, I've optimized the process by separating the tasks into two distinct jobs: Job 1: Path Filtering Job 2: Build and Push Docker Images Explanation: To address this, I had to ensure that the Docker Hub login and environment setup steps were completed in the same job as the build and push operations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot that we need to build the docker image for nlu as well "hexabot-nlu"
file: ./frontend/Dockerfile | ||
platforms: linux/amd64,linux/arm64 | ||
push: true | ||
tags: ${{ secrets.DOCKERHUB_USERNAME }}/hexabot-frontend:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tags: ${{ secrets.DOCKERHUB_USERNAME }}/hexabot-frontend:latest | |
tags: hexastack/hexabot-ui:latest |
if: ${{ needs.paths-filter.outputs.widget == 'true' }} | ||
uses: docker/build-push-action@v6 | ||
with: | ||
context: ./ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
context: ./ | |
context: ./widget |
I think we need to set the widget context like this. Can you push and check ?
file: ./api/Dockerfile | ||
platforms: linux/amd64,linux/arm64 | ||
push: true | ||
tags: ${{ secrets.DOCKERHUB_USERNAME }}/hexabot-api:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tags: ${{ secrets.DOCKERHUB_USERNAME }}/hexabot-api:latest | |
tags: hexastack/hexabot-api:latest |
Motivation
This workflow automates the process of building and pushing Docker images for different parts of the project when changes are pushed to the main branch or triggered manually.
Type of change
Please delete options that are not relevant.
Checklist: