Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/carousel navigation styling #386

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix/carousel navigation styling #386

wants to merge 6 commits into from

Conversation

abdou6666
Copy link
Member

Motivation

Carousel navigation styling :

before :
image

after :
image

Fixes # (issue)

  • Bug fix (non-breaking change which fixes an issue)

@yassinedorbozgithub
Copy link
Contributor

Hi @abdou6666, the carousel looks good with multiple elements
image
Do you thing that we can add a minimum width do to avid having cropped button or/and different user experience for the same carousel component

  • Carousel with only 1 element
    image

@abdou6666
Copy link
Member Author

Hi @abdou6666, the carousel looks good with multiple elements image Do you thing that we can add a minimum width do to avid having cropped button or/and different user experience for the same carousel component

  • Carousel with only 1 element
    image

fixed :
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marrouchi marrouchi marrouchi requested changes

@yassinedorbozgithub yassinedorbozgithub yassinedorbozgithub approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdou6666 @yassinedorbozgithub @marrouchi