Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: plugins strict null check #493

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Conversation

abdou6666
Copy link
Member

@abdou6666 abdou6666 commented Dec 31, 2024

Motivation

This PR fixes duplicate name issue with Plugins & ensure the code compatible with strict null check

Fixes # (issue)

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@abdou6666 abdou6666 requested a review from marrouchi December 31, 2024 13:32
@abdou6666 abdou6666 marked this pull request as draft December 31, 2024 13:32
@abdou6666 abdou6666 force-pushed the fix/plugins-strict-null-check branch from 57f9ea5 to 402a0a2 Compare January 2, 2025 08:55
@abdou6666 abdou6666 marked this pull request as ready for review January 2, 2025 08:55
@abdou6666 abdou6666 force-pushed the fix/plugins-strict-null-check branch from 402a0a2 to 1c61379 Compare January 2, 2025 15:43
api/src/plugins/plugins.service.ts Outdated Show resolved Hide resolved
@marrouchi marrouchi merged commit 0b3036c into main Jan 3, 2025
4 checks passed
@marrouchi marrouchi linked an issue Jan 3, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable strictNullChecks in API tsconfig.json
2 participants