Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: channel ts strict null check #502

Closed
wants to merge 4 commits into from

Conversation

abdou6666
Copy link
Member

Motivation

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@abdou6666 abdou6666 requested a review from marrouchi January 2, 2025 09:15
@abdou6666 abdou6666 force-pushed the fix/channel-ts-strict-null-check branch from 60f948c to 1be203c Compare January 2, 2025 15:43
api/src/chat/services/subscriber.service.ts Outdated Show resolved Hide resolved
api/src/extensions/channels/web/base-web-channel.ts Outdated Show resolved Hide resolved
@abdou6666 abdou6666 requested a review from marrouchi January 3, 2025 09:16
},
assignedTo: null,
avatar: null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
avatar: null,
avatar: req.session.passport.user.avatar,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently user passport user object does not have avatar property unless its miss typed

api/src/chat/schemas/types/channel.ts Outdated Show resolved Hide resolved
api/src/chat/schemas/types/channel.ts Outdated Show resolved Hide resolved
api/src/chat/services/chat.service.ts Outdated Show resolved Hide resolved
api/src/utils/test/fixtures/user.ts Outdated Show resolved Hide resolved
@abdou6666 abdou6666 closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants