Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increased the default number of pagesize #84

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix: increased the default number of pagesize #84

merged 1 commit into from
Sep 25, 2024

Conversation

devamitranjan
Copy link
Contributor

@devamitranjan devamitranjan commented Sep 24, 2024 •
edited
Loading

Motivation

Increased page size to change the default list row count to 10.

Fixes #82

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (Storybook)
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Emnaghz
Emnaghz approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@Emnaghz Emnaghz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

yassinedorbozgithub
yassinedorbozgithub approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@yassinedorbozgithub yassinedorbozgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@marrouchi marrouchi merged commit 9f86b30 into Hexastack:main Sep 25, 2024
2 checks passed
@marrouchi
Copy link
Contributor

Thank you @devamitranjan 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yassinedorbozgithub yassinedorbozgithub yassinedorbozgithub approved these changes

@Emnaghz Emnaghz Emnaghz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🤔 [ISSUE] - Change Grid Default List Row Count from 5 to 10
4 participants
@devamitranjan @marrouchi @Emnaghz @yassinedorbozgithub