Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/api prod dockerfile #98

Merged
merged 3 commits into from
Sep 29, 2024
Merged

Fix/api prod dockerfile #98

merged 3 commits into from
Sep 29, 2024

Conversation

marrouchi
Copy link
Contributor

@marrouchi marrouchi commented Sep 29, 2024

Motivation

Updates the API dockerfile to have multi-targets : dev and prod env.
Removed database-init (Will be only used in dev env)

Fixes #94

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (Storybook)
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@marrouchi marrouchi mentioned this pull request Sep 29, 2024
9 tasks
@marrouchi marrouchi merged commit 620570b into main Sep 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🤔 [ISSUE] - Add production target to the API Dockerfile
2 participants