Feat/initial commit #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marrouchi
requested changes
Nov 25, 2024
| import { Injectable } from '@nestjs/common'; | ||
| import { EventEmitter2, OnEvent } from '@nestjs/event-emitter'; | ||
| import { NextFunction, Request, Response } from 'express'; | ||
| import fetch from 'node-fetch'; |
There was a problem hiding this comment.
Let's not use "node-fetch", you can use the httpService instead.
There was a problem hiding this comment.
attachmentService.uploadProfilePic requires a fetch.Response argument. We’ll either need to keep using fetch or modify the uploadProfilePic method to accommodate HttpService.
Comment on lines
+42
to
+48
| const axiosInstance = axios.create({ | ||
| baseURL: 'https://slack.com/api', | ||
| headers: { | ||
| 'Content-Type': 'application/json; charset=UTF-8', | ||
| Authorization: `Bearer ${access_token}`, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
How about we use the nestjs axios wrapper object instead ? I think you can create a child instance so that you define interceptors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.