Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per-slice fixed_weight beam initialization #1008

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Per-slice fixed_weight beam initialization #1008

merged 5 commits into from
Aug 29, 2023

Conversation

AlexanderSinn
Copy link
Member

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

MaxThevenet
MaxThevenet approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this PR!

src/particles/beam/BeamParticleContainer.H
Comment on lines +247 to +248
/** Array for the z position of all beam particles */
amrex::PODVector<amrex::Real, amrex::PolymorphicArenaAllocator<amrex::Real>> m_z_array {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle, could this be always float if memory is a problem?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that we would also loose precision. I think we would be better off using inverr to make the z distribution per slice.

src/particles/beam/BeamParticleContainer.H Outdated Show resolved Hide resolved
@MaxThevenet
Copy link
Member

So the tests fail just because the seed of RNG has changed, right? Or is there something else that would deserve some work?

@AlexanderSinn
Copy link
Member Author

There was one small issue that is fixed now, other than that it was the RNG.

SeverinDiederichs
SeverinDiederichs approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@SeverinDiederichs SeverinDiederichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for this PR!

@SeverinDiederichs SeverinDiederichs merged commit 20be46d into Hi-PACE:development Aug 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeverinDiederichs SeverinDiederichs SeverinDiederichs approved these changes

@MaxThevenet MaxThevenet Awaiting requested review from MaxThevenet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexanderSinn @MaxThevenet @SeverinDiederichs