Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mini] Fix typo in laser pulse length to pulse duration conversion #1036

Merged
merged 1 commit into from
Nov 8, 2023
Merged

[mini] Fix typo in laser pulse length to pulse duration conversion #1036

merged 1 commit into from
Nov 8, 2023

Conversation

MaxThevenet
Copy link
Member

@MaxThevenet MaxThevenet commented Nov 4, 2023 •
edited
Loading

I think this is incorrect currently

@MaxThevenet MaxThevenet added bug Something isn't working documentation Improvements or additions to documentation component: laser envelope About the laser envelope solver non-backward-compatible Changes the behavior of the code, old input file may give different results labels Nov 4, 2023
SeverinDiederichs
SeverinDiederichs approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@SeverinDiederichs SeverinDiederichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this!

@SeverinDiederichs SeverinDiederichs merged commit a690500 into Hi-PACE:development Nov 8, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeverinDiederichs SeverinDiederichs SeverinDiederichs approved these changes

Assignees
No one assigned
Labels
bug Something isn't working component: laser envelope About the laser envelope solver documentation Improvements or additions to documentation non-backward-compatible Changes the behavior of the code, old input file may give different results
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxThevenet @SeverinDiederichs