Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permanent total to the bottom of checkout, move cart button to above total #264

Closed

Conversation

grablair
Copy link
Contributor

@grablair grablair commented Oct 20, 2024

Fixes #261

  • Adds a line above the checkout button showing the total amount
  • Moves the show/hide cart button to just above new total amount, in the center of the page, and changes the icon to chevrons

Screenshot 2024-10-21 at 11 27 11
Screenshot 2024-10-21 at 11 27 23
Screenshot 2024-10-20 at 14 22 41

Checklist

  • I have read the contributing guidelines.
  • My code is of good quality and follows the coding standards of the project.
  • I have tested my changes, and they work as expected.

Thank you for your contribution! 🎉

@daveearley
Copy link
Contributor

Thank you for this! Apologies for the delay in reviewing. I've implemented similar changes while working on another feature and now need to find a way to incorporate both updates effectively.

@daveearley
Copy link
Contributor

I very much appreciate the effort here, however, I'm going to close this PR, as similar changes have been implemented in the v1 branch.

Thanks again!

Screenshot 2025-01-07 at 17 04 27 Screenshot 2025-01-07 at 17 04 02 Screenshot 2025-01-07 at 17 05 05

@daveearley daveearley closed this Jan 8, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🌟 Customer feedback: improvements for checkout UI on mobile
2 participants