Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : add matlab delimiter query #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Jaehaks
Copy link

@Jaehaks Jaehaks commented Mar 16, 2024

There was no delimiters query of matlab.
Add some treesitter delimiters

@HiPhish
Copy link
Owner

HiPhish commented Mar 16, 2024 via email

@Jaehaks
Copy link
Author

Jaehaks commented Mar 17, 2024

Thanks. Can you please add a test file as well?

Thank you for your reply,

@HiPhish I maked the query with some examples and tested using garciparedes/matlab-examples
matlab-examples/numerical-methods/*

@HiPhish
Copy link
Owner

HiPhish commented Mar 17, 2024

I don't know Matlab and I don't have any need to learn it at the moment, so please add a test file yourself. The test file needs to cover all the patterns defined in the query. It would be good if it also works when executed, so that people who run a language server don't see errors and warnings everywhere, but that's not necessary. Please do not just copy-paste a file from the matlab-examples repo, they have a different license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants