-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ 早晚安被动默认关闭 #1730
✨ 早晚安被动默认关闭 #1730
Conversation
审核指南由 Sourcery 提供此 PR 修改了早安/晚安调度任务配置,默认情况下禁用。通过在任务配置中添加两个新参数来实现更改: 任务配置更改的类图classDiagram
class Task {
- module: string
- name: string
- create_status: bool
- default_status: bool
}
note for Task "属性 create_status 和 default_status 是新添加的,默认设置为 False。"
文件级更改
提示和命令与 Sourcery 互动
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis PR modifies the morning/goodnight scheduler task configuration to be disabled by default. The change is implemented by adding two new parameters to the Task configuration: Class diagram for Task configuration changesclassDiagram
class Task {
- module: string
- name: string
- create_status: bool
- default_status: bool
}
note for Task "The attributes create_status and default_status are newly added and set to False by default."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @HibiKier - 我已经审查了你的更改,它们看起来很棒!
这是我在审查期间查看的内容
- 🟢 一般问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将利用反馈来改进你的审查。
Original comment in English
Hey @HibiKier - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
增强功能:
Original summary in English
Summary by Sourcery
Enhancements: