Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ 早晚安被动默认关闭 #1730

Merged
merged 1 commit into from
Nov 17, 2024
Merged

✨ 早晚安被动默认关闭 #1730

merged 1 commit into from
Nov 17, 2024

Conversation

HibiKier
Copy link
Owner

@HibiKier HibiKier commented Nov 17, 2024

Summary by Sourcery

增强功能:

  • 在调度器插件中将“早晚安”任务的默认状态设置为禁用。
Original summary in English

Summary by Sourcery

Enhancements:

  • Set the default status of the '早晚安' task to disabled in the scheduler plugin.

Copy link

sourcery-ai bot commented Nov 17, 2024

审核指南由 Sourcery 提供

此 PR 修改了早安/晚安调度任务配置,默认情况下禁用。通过在任务配置中添加两个新参数来实现更改:create_statusdefault_status,两者均设置为 False。

任务配置更改的类图

classDiagram
    class Task {
        - module: string
        - name: string
        - create_status: bool
        - default_status: bool
    }
    note for Task "属性 create_status 和 default_status 是新添加的,默认设置为 False。"
Loading

文件级更改

更改 详情 文件
修改了早安/晚安调度任务配置
  • 将 create_status 设置为 False 以防止自动创建
  • 将 default_status 设置为 False 以默认禁用任务
zhenxun/builtin_plugins/scheduler/morning.py

提示和命令

与 Sourcery 互动

  • 触发新审核: 在拉取请求上评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审核评论。
  • 从审核评论生成 GitHub 问题: 通过回复审核评论请求 Sourcery 创建一个问题。
  • 生成拉取请求标题: 在拉取请求标题的任何地方写 @sourcery-ai 以随时生成标题。
  • 生成拉取请求摘要: 在拉取请求正文的任何地方写 @sourcery-ai summary 以随时生成 PR 摘要。您也可以使用此命令指定摘要应插入的位置。

自定义您的体验

访问您的仪表板以:

  • 启用或禁用审核功能,例如 Sourcery 生成的拉取请求摘要、审核指南等。
  • 更改审核语言。
  • 添加、删除或编辑自定义审核说明。
  • 调整其他审核设置。

获取帮助

Original review guide in English

Reviewer's Guide by Sourcery

This PR modifies the morning/goodnight scheduler task configuration to be disabled by default. The change is implemented by adding two new parameters to the Task configuration: create_status and default_status, both set to False.

Class diagram for Task configuration changes

classDiagram
    class Task {
        - module: string
        - name: string
        - create_status: bool
        - default_status: bool
    }
    note for Task "The attributes create_status and default_status are newly added and set to False by default."
Loading

File-Level Changes

Change Details Files
Modified the morning/goodnight scheduler task configuration
  • Set create_status to False to prevent automatic creation
  • Set default_status to False to keep the task disabled by default
zhenxun/builtin_plugins/scheduler/morning.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HibiKier - 我已经审查了你的更改,它们看起来很棒!

这是我在审查期间查看的内容
  • 🟢 一般问题:一切看起来都很好
  • 🟢 安全性:一切看起来都很好
  • 🟢 测试:一切看起来都很好
  • 🟢 复杂性:一切看起来都很好
  • 🟢 文档:一切看起来都很好

Sourcery 对开源项目免费 - 如果你喜欢我们的审查,请考虑分享它们 ✨
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将利用反馈来改进你的审查。
Original comment in English

Hey @HibiKier - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@HibiKier HibiKier merged commit 5e4a414 into main Nov 17, 2024
1 of 2 checks passed
@HibiKier HibiKier deleted the feature/morinig-set branch November 17, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant