tidy up the code a bit

HicServices · Sep 25, 2023 · a817484 · a817484
1 parent 3a0f74f
commit a817484
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/DrsPlugin/Attachers/DrsFileAttacher.cs b/DrsPlugin/Attachers/DrsFileAttacher.cs
@@ -181,7 +181,6 @@ private void UpdateRAWWithImageArchiveLocations(IDataLoadJob job, Dictionary<str
             if (!entry.Any())
                 throw new InvalidOperationException($"There are no file mappings for archive: {archive}");
 
-            //here?
             var query =
                 $"UPDATE [{TableName}] SET {ImageArchiveUriColumnName} = CONCAT('{archive}!', {FilenameColumnName}) WHERE {FilenameColumnName} IN ('{string.Join("','", entry)}')";
 

diff --git a/DrsPlugin/Extraction/DRSImageExtraction.cs b/DrsPlugin/Extraction/DRSImageExtraction.cs
@@ -56,7 +56,6 @@ public override DataTable ProcessPipelineData(DataTable toProcess, IDataLoadEven
 
             if (string.IsNullOrWhiteSpace(row[ImageUriColumnName].ToString()))
             {
-                //here is a skip
                 listener.OnNotify(this, new NotifyEventArgs(ProgressEventType.Warning,
                     $"Row {progress} does not have a corresponding image, [{ImageUriColumnName}] is empty."));
                 continue;
@@ -83,9 +82,10 @@ public override DataTable ProcessPipelineData(DataTable toProcess, IDataLoadEven
                 {
                     File.Copy(Path.Combine(PathToImageArchive, sourceFileName), newFilename);
                 }
-                catch (Exception e)
+                catch (Exception e) //todo this should handle the exceptions better
                 {
-
+                    listener.OnNotify(this, new NotifyEventArgs(ProgressEventType.Information,
+                               $"Failed to copy file (${sourceFileName})."));
                 }
 
                 continue;