Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rdmp branch #40

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Update rdmp branch #40

merged 2 commits into from
Sep 20, 2023

Conversation

JFriel
Copy link
Collaborator

@JFriel JFriel commented Sep 20, 2023

Plugin seems to install ok, but is not visible via the UI

@jas88
Copy link
Member

jas88 commented Sep 20, 2023

@JFriel if "not visible via the UI" means it doesn't show in the Plugins tree branch, that's a small update needed to RDMP - loaded plugins aren't currently shown there.

@JFriel
Copy link
Collaborator Author

JFriel commented Sep 20, 2023

@jas88 Yes, the Plugin tree is empty after loading the plugin - Same with RDMP.Dicom, however RdmpExtentions fails differently. Is this a known issue? Or a new regression?

@jas88
Copy link
Member

jas88 commented Sep 20, 2023

@JFriel Known to me, I've just noted it in the RDMP repo and should have a fix for that soon: HicServices/RDMP#1633 - nothing HICplugin specific there, so we could go ahead and merge this PR if the plugin itself is working OK against 8.1?

@JFriel
Copy link
Collaborator Author

JFriel commented Sep 20, 2023

@jas88 I don't believe it is working correctly. I am unable to use any of the expected functionality, and RDMP doesn't appear to be registering the plugin at all

Edit: Was a local issue

@JFriel JFriel marked this pull request as ready for review September 20, 2023 15:29
@JFriel JFriel merged commit c931f0d into main Sep 20, 2023
1 check passed
@jas88 jas88 deleted the update-rdmp-branch branch October 6, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants