Skip to content

Commit

Permalink
Fix bcl.AsyncInterfaces issue in plugins (#1835)
Browse files Browse the repository at this point in the history
* Fix bcl.AsyncInterfaces issue in plugins

* Remove AsyncInterfaces ref

* tidy up docs

---------

Co-authored-by: James A Sutherland <>
Co-authored-by: James Friel <[email protected]>
  • Loading branch information
jas88 and JFriel authored May 20, 2024
1 parent 333d1e6 commit d110fe6
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 7 deletions.
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## Changed

- Improve error messages for Multi-ExtractionIdentifier extractions
- Add Microsoft.Bcl.AsyncInterfaces 6.0.0 for plugin dependancy tree
- Add prompt to rename container when adding a cohort filter
- Allow for column selection when using the RemoteTableAttacher
- Fix to remove stack trace button from non error popups
Expand Down
1 change: 0 additions & 1 deletion Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,5 @@
<PackageVersion Include="NSubstitute" Version="5.1.0"/>
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.9.0"/>
<PackageVersion Include="coverlet.collector" Version="6.0.2"/>
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0" />
</ItemGroup>
</Project>
1 change: 0 additions & 1 deletion Documentation/CodeTutorials/Packages.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,4 @@
| Autoupdater.NET.Official | [GitHub](https://github.com/ravibpatel/AutoUpdater.NET) | MIT | Manages updating of the RDMP windows client directly from the RDMP GitHub Releases|
| ConsoleControl | [GitHub](https://github.com/dwmkerr/consolecontrol) | MIT | Runs RDMP cli subprocesses|
| Terminal.Gui | [GitHub](https://github.com/gui-cs/Terminal.Gui) | [MIT](https://opensource.org/licenses/MIT) | Console user-interface|
| Microsoft.Bcl.AsyncInterfaces | [GitHub](https://github.com/dotnet/runtime) |[MIT](https://opensource.org/licenses/MIT) | |
[DBMS]: ./Glossary.md#DBMS
3 changes: 1 addition & 2 deletions Rdmp.Core/Curation/Data/SafeDirectoryCatalog.cs
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ public static class SafeDirectoryCatalog
"libarchive.net.dll",
"mapsdirectlytodatabasetable.dll",
"mathnet.numerics.dll",
"microsoft.bcl.asyncinterfaces.dll",
"microsoft.csharp.dll",
"microsoft.data.sqlclient.dll",
"microsoft.data.sqlclient.sni.dll",
Expand Down Expand Up @@ -404,4 +403,4 @@ public static class SafeDirectoryCatalog
"wpfgfx_cor3.dll",
"yamldotnet.dll"
};
}
}
1 change: 0 additions & 1 deletion Rdmp.Core/Rdmp.Core.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,6 @@
<PackageReference Include="SSH.NET" />
<PackageReference Include="Terminal.Gui" />
<PackageReference Include="YamlDotNet" />
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces"/>
</ItemGroup>
<ItemGroup>
<EmbeddedResource Include="Curation\KeywordHelp.txt">
Expand Down
2 changes: 1 addition & 1 deletion directory.build.props
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>
<PropertyGroup>
<LangVersion>11.0</LangVersion>
<Version>8.1.6</Version>
<Version>8.1.4</Version>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
</PropertyGroup>
</Project>

0 comments on commit d110fe6

Please sign in to comment.