Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Migration Strategy to account for all PK values #2022

Merged

Conversation

JFriel
Copy link
Collaborator

@JFriel JFriel commented Oct 10, 2024

Proposed Change

The current migration strategy when moving items from staging -> live only matches on the first primary key, it should match on all of the primary keys

Type of change

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update
  • Other (if none of the other choices apply)

Checklist

By opening this PR, I confirm that I have:

  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Created or updated any tests if relevant
  • Have validated this change against the Test Plan
  • Requested a review by one of the repository maintainers
  • Have written new documentation or updated existing documentation to detail any new or updated functionality and how to use it
  • Have added an entry into the changelog

@JFriel JFriel changed the base branch from develop to release/8.4.0 October 24, 2024 07:13
@JFriel JFriel requested a review from a team October 24, 2024 09:52
@JFriel JFriel marked this pull request as ready for review October 24, 2024 09:52
@rdteviotdale rdteviotdale merged commit 65c2f42 into release/8.4.0 Nov 6, 2024
5 checks passed
@rdteviotdale rdteviotdale deleted the bugfix/RDMP-256-migrate-composite-pk-issue branch November 6, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants