Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Added fexible and editable android manifest to config #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanBrooker
Copy link

This is a follow up to my comments in #181 on the need to have a flexible way to build and edit the AndroidManifest.xml

This PR provides a manifest object stored as nested hashes. It allows for user to change all default manifest options and add additional nodes arbitrarily. It removes the hardcoded manifest xml that exists currently

For instance to set the theme on application in the Rakefile

app.manifest.child('application')['android:theme'] = '@style/AppTheme'

We can also grab the main activity and add a property to it

app.manifest.child('application').children('activity')[0]['android:label'] = 'New Label'

I've made an effort to not break the existing config vars such as services, permissions etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant