When code signing, a connection to the Apple time servers is required. #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you’re building without an internet connection (airplane, train, etc), then can be impossible to build. Particularly when you need to use code signing during development. Implemented the `codesign_disable_timestamp` config variable to pass the `—timestamp=none` flag to the `codesign` executable. Defaults to false. Only for macOS at the moment.
|
Thanks for the contribution! Should we set it to true when building in development mode? |
|
I suppose you could always disable the timestamp during development, and have it enabled for release. Which is basically what I'm doing now in my Rakefile. I don't really see a downside to that, as long as it's enabled for the release build. Then we wouldn't need the new flag. |
|
Changed the default based on the |
|
bump -- any hope of getting this merged in? I ran into this problem again with 4.18 when trying to build in a non-wifi situation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you’re building without an internet connection (airplane, train,
etc), then it can be impossible to build. Particularly when you need
to use code signing during development. Implemented the
codesign_disable_timestampconfig variable to pass the—timestamp=noneflag to thecodesignexecutable. Defaultsto false. Only for macOS at the moment.