Fixed before input bug (facebook#31957)

HitenChawda46 · Jan 2, 2025 · 85c6cbc · 85c6cbc
1 parent c01b805
commit 85c6cbc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/react-dom-bindings/src/events/plugins/BeforeInputEventPlugin.js b/packages/react-dom-bindings/src/events/plugins/BeforeInputEventPlugin.js
@@ -59,7 +59,7 @@ function registerEvents() {
   registerTwoPhaseEvent('onBeforeInput', [
     'compositionend',
     'keypress',
-    'textInput',
+    'beforeinput',
     'paste',
   ]);
   registerTwoPhaseEvent('onCompositionEnd', [
@@ -281,7 +281,7 @@ function getNativeBeforeInputChars(
 
       hasSpaceKeypress = true;
       return SPACEBAR_CHAR;
-
+    case 'beforeinput': // ensure that before input event is listened to
     case 'textInput':
       // Record the characters to be added to the DOM.
       const chars = nativeEvent.data;

diff --git a/packages/react-dom/src/events/plugins/__tests__/BeforeInputEventPlugin-test.js b/packages/react-dom/src/events/plugins/__tests__/BeforeInputEventPlugin-test.js
@@ -123,7 +123,7 @@ describe('BeforeInputEventPlugin', () => {
     },
     {
       eventSimulator: simulateEvent,
-      eventSimulatorArgs: ['textInput', {data: 'abcß'}],
+      eventSimulatorArgs: ['beforeinput', {data: 'abcß'}],
     },
     {
       eventSimulator: simulateKeyboardEvent,
@@ -161,7 +161,7 @@ describe('BeforeInputEventPlugin', () => {
     },
     {
       eventSimulator: simulateEvent,
-      eventSimulatorArgs: ['textInput', {data: '\uD83D\uDE0A'}],
+      eventSimulatorArgs: ['beforeinput', {data: '\uD83D\uDE0A'}],
     },
     {
       eventSimulator: simulateKeyboardEvent,
@@ -236,7 +236,7 @@ describe('BeforeInputEventPlugin', () => {
         {
           run: ({beforeInputEvent, spyOnBeforeInput}) => {
             expect(spyOnBeforeInput).toHaveBeenCalledTimes(1);
-            expect(beforeInputEvent.nativeEvent.type).toBe('textInput');
+            expect(beforeInputEvent.nativeEvent.type).toBe('beforeinput');
             expect(beforeInputEvent.type).toBe('beforeinput');
             expect(beforeInputEvent.data).toBe('abcß');
           },
@@ -288,7 +288,7 @@ describe('BeforeInputEventPlugin', () => {
         {
           run: ({beforeInputEvent, spyOnBeforeInput}) => {
             expect(spyOnBeforeInput).toHaveBeenCalledTimes(1);
-            expect(beforeInputEvent.nativeEvent.type).toBe('textInput');
+            expect(beforeInputEvent.nativeEvent.type).toBe('beforeinput');
             expect(beforeInputEvent.type).toBe('beforeinput');
             expect(beforeInputEvent.data).toBe('\uD83D\uDE0A');
           },