Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to Int in cring_Z #2000

Merged
merged 15 commits into from
Jul 5, 2024
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/Algebra/Rings/Matrix.v
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
From HoTT Require Import Basics.
From HoTT Require Import Algebra.Rings.Matrix.
From HoTT Require Import Spaces.Nat.Core Spaces.List.Core.
From HoTT Require Import Algebra.Rings.Z Spaces.BinInt.Core Algebra.Rings.CRing.
From HoTT Require Import Algebra.Rings.Z Spaces.Int Algebra.Rings.CRing.
From HoTT Require Import Classes.interfaces.canonical_names.

Local Open Scope mc_scope.
Expand Down Expand Up @@ -38,7 +38,7 @@ Definition test2_B := Build_Matrix' nat 4 4

Definition test2 : entries test2_A = entries test2_B := idpath.

Local Open Scope binint_scope.
Local Open Scope int_scope.

(** Matrices with ring entries can be multiplied *)

Expand Down
4 changes: 2 additions & 2 deletions theories/Algebra/AbGroups/Cyclic.v
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Require Import Basics Types WildCat.Core Truncations.Core
AbelianGroup AbHom Centralizer AbProjective
Groups.FreeGroup AbGroups.Z BinInt.Core Spaces.Int.
Groups.FreeGroup AbGroups.Z Spaces.Int.

(** * Cyclic groups *)

Expand Down Expand Up @@ -71,7 +71,7 @@ Defined.

(** The map sending the generator to [1 : Int]. *)
Definition Z1_to_Z `{Funext} : ab_Z1 $-> abgroup_Z
:= Z1_rec (G:=abgroup_Z) 1%binint.
:= Z1_rec (G:=abgroup_Z) 1%int.

(** TODO: Prove that [Z1_to_Z] is a group isomorphism. *)

Expand Down
16 changes: 8 additions & 8 deletions theories/Algebra/AbGroups/Z.v
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Require Import Basics.
Require Import Spaces.Pos.Core Spaces.BinInt.
Require Import Spaces.Pos.Core Spaces.Int.
Require Import Algebra.AbGroups.AbelianGroup.

Local Set Universe Minimization ToSet.
Expand All @@ -8,17 +8,17 @@ Local Set Universe Minimization ToSet.

(** See also Cyclic.v for a definition of the integers as the free group on one generator. *)

Local Open Scope binint_scope.
Local Open Scope int_scope.

(** TODO: switch to [Int] *)
Definition abgroup_Z@{} : AbGroup@{Set}.
Proof.
snrapply Build_AbGroup.
- refine (Build_Group BinInt binint_add 0 binint_negation _); repeat split.
- refine (Build_Group Int int_add 0 int_neg _); repeat split.
+ exact _.
+ exact binint_add_assoc.
+ exact binint_add_0_r.
+ exact binint_add_negation_l.
+ exact binint_add_negation_r.
- exact binint_add_comm.
+ exact int_add_assoc.
+ exact int_add_0_r.
+ exact int_add_neg_l.
+ exact int_add_neg_r.
- exact int_add_comm.
Defined.
Loading
Loading