Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equivalence cleanups #2124

Merged
merged 4 commits into from
Oct 26, 2024
Merged

Conversation

jdchristensen
Copy link
Collaborator

Mainly changes Types/Equiv.v:

  • Removed rewrites from one proof.
  • Moved most things that don't depend on Funext out of the Funext section. I think the new order also makes the structure more clear.
  • Fix formatting of some comments and indentation.

In Equiv/BiInv.v, I just reduced the imports.

#[local]
Hint Immediate isequiv_contr_map : typeclass_instances.
(** As usual, we can't make both of these [Instances]. *)
#[export] Hint Immediate isequiv_contr_map : typeclass_instances.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already a global export, but it was done after the section was closed, so there is no change here.

Comment on lines +26 to +27
lhs_V nrapply transport_paths_l.
lhs_V nrapply transport_compose.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the only changes to the proofs.

Copy link
Collaborator

@Alizter Alizter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, free to merge after one suggestion

theories/Equiv/BiInv.v Outdated Show resolved Hide resolved
@jdchristensen
Copy link
Collaborator Author

@Alizter Thanks. I also updated one comment in Types/Sigma.v

@jdchristensen jdchristensen merged commit 1bae406 into HoTT:master Oct 26, 2024
22 checks passed
@jdchristensen jdchristensen deleted the equiv-cleanups branch October 26, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants