-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nats: db proposal #42
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
f3812d3
add nats util crate
JettTech f3085c4
clean-up
JettTech 7d72ac5
clean comments
JettTech 54ce72c
edit trait
JettTech ea1c583
add mongo consts, update err types
JettTech e07f57d
resolve borrow
JettTech 02bc2c1
add all tests
JettTech c3f46a8
elevate rust setup dir
JettTech 6597c31
update server tests
JettTech bf6f165
add back db proposal
JettTech 8042def
clean db
JettTech b0cd5ae
clearn
JettTech 0f95cf4
tidy
JettTech 71ed439
Merge branch 'nats-baseline' into nats-crates
JettTech fa5efb6
Merge branch 'nats-baseline' into nats-crates
JettTech 634364c
update aliases
JettTech 40ff0e4
Merge branch 'nats-baseline' into nats-crates
JettTech ad3da0d
Merge branch 'main' into nats-crates
JettTech 07a710a
Merge branch 'nats-crates' of github.com:Holo-Host/holo-host into nat…
JettTech f5d631b
Merge branch 'main' into nats-crates
JettTech ff868de
Merge branch 'main' into nats-crates
JettTech 796b97c
Merge branch 'nats-crates' of github.com:Holo-Host/holo-host into nat…
JettTech 43e1502
update gitignore
JettTech e2e2a4e
clean up
JettTech 819df09
update file descriptions, clean
JettTech af56c80
edit workload and host schmeas
JettTech 1d38a02
adjusments
JettTech 41253be
add serde skip and optional mongo ids on schema structs, update workl…
JettTech 1485022
clean
JettTech 97f1fb4
Merge branch 'main' into nats-crates
JettTech 86fa6d0
Merge branch 'main' into nats-crates
JettTech a1f7360
update js client names and types, make consumer accept endpoint gener…
JettTech 4aab1e8
update service lib to explicitly state return type
JettTech 5a6461a
clean up resp msg handling
JettTech 6160244
clean up helper
JettTech 6cb6c01
add id to workload_status
JettTech eea5cb6
Merge branch 'main' into nats-crates
JettTech 670136d
fix types
JettTech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we really be calling into MongoDB from the host_agent code? The agent should communicate with the services running centrally, which in turn is the only touch point to the central MongoDB instance. All communication from the agent goes through the API, which is now using NATS as a transport and won't go direct to things like MongoDB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're 100% correct. This was added here for the convenience of testing in the first iteration. The host agents will not have a mongodb instance in production. I actually already have a PR out that both adds the workload api for the orchestrator and separates out the api for the orchestrator and host such that only the orchestrator service api has access to mongodb.