131: Add workload service test suite #83
Conversation
JettTech
changed the title
| @@ -19,10 +20,17 @@ strum_macros = "0.25" | |||
| async-trait = "0.1.83" | |||
| semver = "1.0.24" | |||
| rand = "0.8.5" | |||
| mongodb = "3.1" | |||
| mongodb = { version = "3.1", features = ["sync"] } | |||
There was a problem hiding this comment.
| mongodb = { version = "3.1", features = ["sync"] } | |
| [dependencies.mongodb] | |
| version = 3.1 | |
| features = ["sync"] |
There was a problem hiding this comment.
@zeeshan595 - What is the pull for stretching the dependency into multiple lines? Personally, I'd rather just stick to the single line standard we already have in the repo, but I'm open to hearing a pull for a different style.
There was a problem hiding this comment.
Given that this feedback relates to team code norms and preferred patterns/styles, I will go ahead and raise this feedback as a topic to discuss at our team meeting tomorrow. There we can decide as a whole, what our team preference will be for this subject and can start to put together our code style guide.
Based on the outcome of this conversation, I will either create a new PR to style all dependencies with features within this crate and all other crates in the repo as suggested here, or leave it be.
Contributes to #131