Fix after debugging

.github/workflows/extension-PR.yaml

@@ -30,12 +30,10 @@ jobs:
         working-directory: holo-key-manager-extension
 
       - name: Build extension
-        if: steps.cache-build.outputs.cache-hit != 'true'
         run: pnpm build
         working-directory: holo-key-manager-extension
 
       - name: Build client
-        if: steps.cache-build.outputs.cache-hit != 'true'
         run: pnpm build
         working-directory: holo-key-manager-js-client
 

.github/workflows/extension.yaml

@@ -71,8 +71,8 @@ jobs:
         run: pnpm build
         working-directory: holo-key-manager-extension
 
-      - name: Build and pack client
-        run: pnpm buildPack
+      - name: Build client
+        run: pnpm build
         working-directory: holo-key-manager-js-client
 
       - name: Run e2e tests

.husky/pre-commit

@@ -1,3 +1 @@
-#!/usr/bin/env sh
-. "$(dirname -- "$0")/_/husky.sh"
 npx lint-staged

package.json

@@ -19,7 +19,6 @@
 		"prepare": "husky install",
 		"test": "concurrently \"pnpm e2e-tests\" \"cd holo-key-manager-extension && pnpm test\" \"cd holo-key-manager-js-client && pnpm test\"",
 		"e2e-tests": "vitest run"
-
 	},
 	"devDependencies": {
 		"@rollup/plugin-node-resolve": "^15.2.3",
@@ -35,7 +34,7 @@
 		"eslint-plugin-svelte": "^2.42.0",
 		"express": "^4.19.2",
 		"globals": "^15.8.0",
-		"husky": "^9.1.0",
+		"husky": "^9.1.1",
 		"jszip": "^3.10.1",
 		"lint-staged": "^15.2.5",
 		"prettier": "^3.3.3",

tests/helpers.ts

@@ -8,7 +8,6 @@ import { vi } from 'vitest';
 
 export const launchBrowserWithExtension = async (extensionPath: string): Promise<Browser> => {
 	return launch({
-		dumpio: true,
 		headless: true,
 		args: [`--disable-extensions-except=${extensionPath}`, `--load-extension=${extensionPath}`]
 	});
@@ -63,13 +62,9 @@ export const findButtonExtensionByText = (context: Page) =>
 export const findTextBySelector = (context: Page) => findElementByText(context, '');
 
 export const startServer = (port: number = 3007): Server => {
-	try {
-		const app = express();
-		app.use(express.static(resolve('./holo-key-manager-js-client')));
-		return app.listen(port);
-	} catch (error) {
-		throw new Error(`Failed to start server: ${error}`);
-	}
+	const app = express();
+	app.use(express.static(resolve('./holo-key-manager-js-client')));
+	return app.listen(port);
 };
 
 export const waitForNewPage = (browser: Browser): Promise<Page> =>

tests/index.test.ts

@@ -13,7 +13,7 @@ import setupFlowTest from './setupFlow';
 
 dotenv.config();
 
-const EXTENSION_ID = process.env.CHROME_ID || 'eggfhkdnfdhdpmkfpihjjbnncgmhihce';
+const EXTENSION_ID = process.env.CHROME_ID;
 
 const downloadPath = resolve('./downloads');
 

tests/needsSetup.ts

@@ -9,39 +9,6 @@ export default async function needsSetupTest(browser: Browser) {
 	const page = await browser.newPage();
 	await page.goto('http://localhost:3007/tests/test.html');
 
-	// Find the service worker target
-	const swTarget = await browser.waitForTarget((target) => target.type() === 'service_worker');
-
-	// Create a new page for the service worker
-	const swPage = await swTarget.createCDPSession();
-
-	// Enable console logging for the service worker
-	await swPage.send('Runtime.enable');
-
-	// Listen for console messages from the service worker
-	swPage.on('Runtime.consoleAPICalled', (event) => {
-		const { type, args } = event;
-		const formattedArgs = args.map((arg) => arg.value || arg.description).join(', ');
-		console.log(`Service Worker Console [${type}]: ${formattedArgs}`);
-	});
-
-	await page.evaluate(() => {
-		window.addEventListener('message', (event) => {
-			console.log(event.data);
-		});
-	});
-
-	page.on('console', async (message) => {
-		const type = message.type();
-		const text = await message.text();
-		const args = await Promise.all(message.args().map((arg) => arg.jsonValue()));
-
-		const formattedArgs = args.map((arg) => JSON.stringify(arg)).join(', ');
-		console.log(
-			`Console message [${type}]: ${text}${formattedArgs ? ` | Args: ${formattedArgs}` : ''}`
-		);
-	});
-
 	const findTextOnPage = findTextBySelector(page);
 
 	const signUpButton = await findTextOnPage('Sign Up');

tests/setupFlow.ts

@@ -21,16 +21,6 @@ export default async function setupFlowTest(browser: Browser, EXTENSION_ID: stri
 
 	const page = await openExtensionPage(browser, EXTENSION_ID);
 
-	const targets = browser.targets();
-	console.log(targets);
-	const serviceWorkerTarget = targets.find((target) => target.type() === 'service_worker');
-
-	if (serviceWorkerTarget) {
-		console.log('Service worker from this extension is working');
-	} else {
-		console.log('Service worker from this extension is not detected');
-	}
-
 	const setupButton = await findButtonExtensionByText(page)('Setup');
 
 	const setupPageContent = await findTextBySelector(page)('Setup Required');